Skip to content

feat: add experimental --exclude-allocations setting#425

Merged
not-matthias merged 2 commits into
mainfrom
cod-3016-add-runneraction-setting-to-exclude-memory-allocators
Jul 13, 2026
Merged

feat: add experimental --exclude-allocations setting#425
not-matthias merged 2 commits into
mainfrom
cod-3016-add-runneraction-setting-to-exclude-memory-allocators

Conversation

@not-matthias

@not-matthias not-matthias commented Jun 26, 2026

Copy link
Copy Markdown
Member

No description provided.

@codspeed-hq

codspeed-hq Bot commented Jun 26, 2026 •
edited
Loading

Copy link
Copy Markdown

Merging this PR will not alter performance

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

✅ 7 untouched benchmarks

Comparing cod-3016-add-runneraction-setting-to-exclude-memory-allocators (58d994a) with main (f149eec)

Open in CodSpeed

@not-matthias not-matthias marked this pull request as ready for review June 26, 2026 17:14
@greptile-apps

greptile-apps Bot commented Jun 26, 2026 •
edited
Loading

Copy link
Copy Markdown

Greptile Summary

This PR adds an experimental way to exclude allocation time from runs. The main changes are:

  • New --experimental-exclude-allocations CLI and environment setting.
  • Propagation of the setting through run and exec executor configuration.
  • Upload metadata support that includes the setting only when it is enabled.
  • Test fixture updates for the new metadata field.

Confidence Score: 5/5

This looks safe to merge.

  • No blocking issues found in the changed code.

Important Files Changed

Filename Overview
src/cli/experimental.rs Adds the experimental exclude-allocations argument and updates the experimental cycle-estimation naming.
src/cli/exec/mod.rs Passes the experimental exclude-allocations setting into exec orchestration.
src/cli/run/mod.rs Passes the experimental exclude-allocations setting into run orchestration and defaults it off.
src/executor/config.rs Adds exclude-allocations to orchestrator and executor configuration.
src/run_environment/provider.rs Copies the executor setting into runner upload metadata.
src/upload/interfaces.rs Adds the upload metadata field while omitting the default false value from JSON.
src/upload/upload_metadata.rs Updates metadata hash fixtures for the new runner field.

Reviews (5): Last reviewed commit: "refactor: align cycle-estimation flag wi..." | Re-trigger Greptile

greptile-apps[bot]
greptile-apps Bot reviewed Jun 26, 2026
View reviewed changes
Comment thread src/upload/interfaces.rs
@not-matthias not-matthias force-pushed the cod-3016-add-runneraction-setting-to-exclude-memory-allocators branch from 16220f0 to 9f62198 Compare June 26, 2026 17:28
@not-matthias not-matthias force-pushed the cod-3016-add-runneraction-setting-to-exclude-memory-allocators branch from 9f62198 to ca7c0f6 Compare July 3, 2026 08:43
GuillaumeLagrange
GuillaumeLagrange approved these changes Jul 10, 2026
View reviewed changes

@GuillaumeLagrange GuillaumeLagrange left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

olgtm

Comment thread src/cli/experimental.rs Outdated
Comment thread src/cli/experimental.rs Outdated
@not-matthias not-matthias force-pushed the cod-3016-add-runneraction-setting-to-exclude-memory-allocators branch from ca7c0f6 to f356975 Compare July 13, 2026 09:55
@not-matthias
feat: add experimental --exclude-allocations setting
1aec4f6 
Add an experimental `--exclude-allocations` flag (env
`CODSPEED_EXCLUDE_ALLOCATIONS`) that signals the backend to exclude
memory allocation time from simulation results.

The value is surfaced as `runner.excludeAllocations` in the upload
metadata so the backend can gate comparability and history on it: runs
with different values are not comparable. The field is additive, so the
metadata version stays at 10 and older payloads remain compatible.

COD-3016
@not-matthias
refactor: align cycle-estimation flag with experimental naming scheme
58d994a
@not-matthias not-matthias force-pushed the cod-3016-add-runneraction-setting-to-exclude-memory-allocators branch from f356975 to 58d994a Compare July 13, 2026 10:03
@not-matthias not-matthias merged commit 58d994a into main Jul 13, 2026
21 checks passed
@not-matthias not-matthias deleted the cod-3016-add-runneraction-setting-to-exclude-memory-allocators branch July 13, 2026 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@greptile-apps greptile-apps[bot] greptile-apps[bot] left review comments
@GuillaumeLagrange GuillaumeLagrange GuillaumeLagrange approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@not-matthias @GuillaumeLagrange